@pierre-gilles : I just fixed all the feedback
1 Like
Thanks for the feedback, it’s much better!
I have some UX feedback and a technical one, nothing too serious 
We’re on the right track, I think this can be merged soon!
1 Like
I’ve just corrected your latest feedback
Thanks for the feedback
I still have a few review comments on small details : https://github.com/GladysAssistant/Gladys/pull/1900#pullrequestreview-1726960919
Thanks for the review
I’ve made the changes except for the « deselect all » button. I’m not sure that’s useful. We’ll see depending on how everyone uses it. What do you think?
It all depends on the number of tags added.
Ok, I’m happy to see it in real use, but in my opinion the request will come quickly! When I tested I found it inconvenient
1 Like
It’s all good for me @Lokkye, there’s just ESLint yelling on your last push 
And I just have one question about the Cypress tests:
After these two little things, it’s good for me to merge! Can’t wait to publish this
Edit: Ah wait, small regression on the « New scene » view:
Before:
After:
It looked cleaner before, didn’t it?
Yes it’s better with the button at the bottom
It doesn’t visually bother me, but the button at the bottom makes much more sense.
The flow is Name > Icon > Confirm.
@pierre-gilles @Hizo @lmilcent : Yes I agree with you. I still wonder how I managed to swap those two components when I wasn’t supposed to touch that code
@pierre-gilles : I just made the fixes on the PR and rebased onto master so you can easily merge it
It’s good for me @Lokkye, thanks for the fixes 
It’s merged into master and will be included in the next Gladys release
I just have a few small notes that weren’t blocking for the review that I noticed:
- With Preact, there’s no need to rename
class=toclassName=. className is a React-specific thing that doesn’t apply to Preact; it’s even recommended to stick withclass= (but className still works) - To hide content on small screens, you can use built-in Bootstrap classes, which avoids re-writing CSS ( Display property · Bootstrap )
2 Likes
This feature is available in Gladys Assistant 4.31! 
I’m closing this thread to free up the votes — feel free to create a new thread if you encounter any bugs with this feature
2 Likes