Hizo
Mars 7, 2022, 2:46
6
Mince, je trouve que ça serait bien pratique.
Encore merci pour tout ton taf !
1 « J'aime »
Bonjour à tous, j’ai commencé à travailler sur la feature. J’ai de bon résultat pour le moment. Il me reste à finir 2-3 truc et à faire les tests unitaire. Je pense avoir une PR d’ici la fin de la semaine
7 « J'aime »
La petite PR qui va bien :
GladysAssistant:master ← callemand:BoxDevices
opened 06:53AM - 31 May 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com)._
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Add a new box for the dashboard who can display a list of devices (like Device in room but without room)
<img width="1102" alt="Screenshot 2023-05-31 at 09 18 11" src="https://github.com/GladysAssistant/Gladys/assets/11317212/ae961e8b-62b0-4116-86e8-2e5cdee4eab1">
<img width="1233" alt="Screenshot 2023-05-31 at 09 17 58" src="https://github.com/GladysAssistant/Gladys/assets/11317212/e54c14a3-5ac6-44ed-99a1-3a8da5e880d2">
4 « J'aime »
Hizo
Mai 31, 2023, 9:10
10
Petite question, pourquoi limiter les types de materiel compatibles avec cette fonctionnalité ?
Merci! Je regarde demain et je te tiens au courant
On n’affiche que ce qu’on est capable d’afficher dans cette box, certaines fonctionnalités n’ont pas vocations à être affichée ici, exemple: les caméras !
Je viens de faire une review de la PR !
GladysAssistant:master ← callemand:BoxDevices
opened 06:53AM - 31 May 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com)._
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Add a new box for the dashboard who can display a list of devices (like Device in room but without room)
<img width="1102" alt="Screenshot 2023-05-31 at 09 18 11" src="https://github.com/GladysAssistant/Gladys/assets/11317212/ae961e8b-62b0-4116-86e8-2e5cdee4eab1">
<img width="1233" alt="Screenshot 2023-05-31 at 09 17 58" src="https://github.com/GladysAssistant/Gladys/assets/11317212/e54c14a3-5ac6-44ed-99a1-3a8da5e880d2">
2 « J'aime »
@pierre-gilles : J’ai fait des retours sur ta review
1 « J'aime »
Trop cool
Je viens de te faire une review!
1 « J'aime »
Merci pour la review. J’ai fait les correctifs en conséquence
1 « J'aime »
Merci pour tes correctifs, ça marche de mon côté maintenant
J’ai quelques feedbacks mais rien de très sérieux. Au niveau des traductions je propose ça :
(Je pense que actuellement c’est un oubli, le texte est dupliqué 2 fois)
Tu trouveras la review complète ici : Add Devices box by callemand · Pull Request #1803 · GladysAssistant/Gladys · GitHub
Merci encore du dev
3 « J'aime »
@pierre-gilles : Normalement, j’ai fixé tous les « problèmes » que tu as remonté.
1 « J'aime »
Merci pour les retours, les traductions par contre est-ce que tu peux mettre les mêmes que sur mon screenshot (placeholder et titre) ?
J’essaie de pousser l’utilisation du terme « widget » dans le front, et non pas « box » ce qui n’est pas très clair pour l’utilisateur
Lokkye
Juin 12, 2023, 11:44
20
C’est vrai que widget est plus clair que box. J’ai fait les changements
Merci pour les changements rapides, il y a juste une petite typo dans les traductions française, c’est « Entrez » et non pas « Enter »
GladysAssistant:master ← callemand:BoxDevices
opened 06:53AM - 31 May 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com)._
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Add a new box for the dashboard who can display a list of devices (like Device in room but without room)
<img width="1102" alt="Screenshot 2023-05-31 at 09 18 11" src="https://github.com/GladysAssistant/Gladys/assets/11317212/ae961e8b-62b0-4116-86e8-2e5cdee4eab1">
<img width="1233" alt="Screenshot 2023-05-31 at 09 17 58" src="https://github.com/GladysAssistant/Gladys/assets/11317212/e54c14a3-5ac6-44ed-99a1-3a8da5e880d2">
Oops my bad, c’est corrigé
1 « J'aime »
Merci pour le correctif, c’est bon pour moi
Beau boulot
J’ai mergé !
2 « J'aime »
Je regarde ça lundi !
