Presence detection via local network

[GBoulvin]

I also had to disable the other CIDRs to be scanned so that it would work…

[AlexTrovato]

@spenceur

Otherwise I have some feedback, is it normal that when you click on the scan button there is no spinner or anything to tell the user that an action has been performed?
Because I can click all I want and I don’t know if it scans

The button is red
I’ll look into adding an animation to the button, without making everything too heavy.

@spenceur

However, I confirm that I don’t see the iPhone on the network despite having unchecked the private WiFi address option (true mac) any idea @AlexTrovato

Uh… hello no, that doesn’t ring a bell… now, if you fiddle a bit with the command line, you can try the command nmap -sn 192.168.1.1/24 (adapting the IP to your network).
If you see your iPhone here, it’s a bug in the Gladys service.
If you don’t see the iPhone, it could come from your machine, the router, the network, the iPhone…

@_Will_71

But what’s strange is the phone being detected several times during the day while I wasn’t at home!

Hmm… a caching issue on the network?
Same as for @spencer, if you fiddle a bit with the command line, disconnect your smartphone from WiFi, wait 1 minute (there is usually a cache on the router), try a nmap -sn 192.168.1.1/24 (adapting the IP to your network).
If you no longer see your device, it’s a problem with the service.
If you still see it, it could come from your machine, the router, the network (but not the smartphone)…

@GBoulvin

I also had to disable the other CIDRs to scan for it to work…

Thanks, I’ll disable the « too greedy » interfaces by default.

[spenceur]

@AlexTrovato

The button is red

Ah it’s supposed to change color xD?
For me it’s still red :-s

[AlexTrovato]

The scan doesn’t stop.

Change the interfaces’ configuration (limit it to the IPs you’re interested in) and restart your Gladys instance… We’ll avoid it catching fire during the night (joke).

I’m putting in place a duration limiter for the scan.
But there won’t be a « little spinning wheel » on the button — the developer is « too expensive ».
We’ll make sure it goes back to blue after being red

[Will_71]

I tried the nmap command and it works fine. When I connect the phone to the Wi-Fi it is in the nmap list, if I disconnect it it no longer appears.

However in Gladys . I restarted Gladys and now it can’t find anything

[Will_71]

I restarted a second time and I got an error message

In the logs the nmap command, however, seems to have worked
![image|690x29](upload://vZiG70xYiCn9kGIM

[pierre-gilles]

@AlexTrovato

I think @pierre-gilles won’t mind if we change the display to show the device name rather than the feature name for presence features.

No problem

@AlexTrovato

If that works, we’ll make a change to disable Docker interfaces by default (and to stop the search that never finishes).

Isn’t there a timeout on a scan? I think beyond 60 seconds of scanning it’s useless, you need to cut it off. Otherwise we risk having processes that accumulate indefinitely

@AlexTrovato

@spenceur, I have my production installation on a Synology, and indeed, no devices were reported, or more precisely, the network discovery never finished.

Isn’t there any indicator that a synchronization is in progress? A small spinner + a short message would be welcome, otherwise it’s very frustrating for the user, they don’t know what’s happening.

[spenceur]

@AlexTrovato

Uh… hello no, that doesn’t ring a bell… now if you play a bit with the command prompt, you can try the command nmap -sn 192.168.1.1/24 (adjusting the IP to your network).
If you see your iPhone here, it’s a bug in the Gladys service.
If you don’t see the iPhone, it could come from your machine, the router, the network, the iPhone…

Hello!
Well, bad news — it does show up with the nmap command; however, without moving, it showed up on 4 scans out of 5.

[Hizo]

Hi,

Personally, it managed to find it — I noticed it by chance.
I removed all the addresses except my local one but it doesn’t see anything anymore.

Even though I added my phone, it tells me it hasn’t seen me since 10:00…

[Will_71]

@AlexTrovato this morning everything seems to be working after Gladys was restarted last night. I added other devices this morning and it’s working correctly.

[GBoulvin]

@AlexTrovato On the first scan I got an alert from my PiHole saying it had blocked Gladys due to too many requests (over 10,000).
Maybe some ISP boxes have this same limit natively, which is why it actually makes sense to restrict it to the primary network…

[GBoulvin]

Small problem and no idea what it is…
Yesterday, I had three other networks (no idea what they’re doing there).
After disabling them, the service worked.
This afternoon, three additional networks appeared, enabled by default and an endless scan…

And I think the ‹ trash › icon has no effect…

[AlexTrovato]

@pierre-gilles

Is there no timeout on a scan? I think beyond 60 seconds of scanning it’s useless, it should be cut off. Otherwise we risk having processes accumulate indefinitely

Scans don’t pile up; to start a new scan, the service must not already be scanning… but if it doesn’t finish, that’s annoying.
I’ll put the « timeout » in place ASAP.

@pierre-gilles

Is there no indicator that a synchronization is in progress? A little spinner + a short message would be welcome, otherwise it’s very frustrating for the user, they don’t know what’s happening.

I’ll try to make something clean, but it won’t be a priority. The « start scan » button changes from blue to red, like with Bluetooth, there’s just no animation.

@GBoulvin

This afternoon, three additional networks appeared, enabled by default and endless scan…

We’ll need to find a way to identify these networks… apparently they are virtual network interfaces…

So, work in progress

For smartphones, I think fixing the « infinite » scan will help make things clearer.

[AlexTrovato]

@GBoulvin

And I think that the ‹ trash › icon has no effect…

I forgot, on one browser, the trash displays a message stating that you cannot delete a network interface.

I also see a typo there…

[AlexTrovato]

For your information, I’m in the process of building a new Docker image (atrovato/gladys:lan-manager available in about 1 hour) with the fixes… I haven’t tested it in a real environment

I’m not sure I’ll have time to test before the weekend, so if anyone brave can reproduce the problem(s) (especially the

[spenceur]

Hello @AlexTrovato
I’m reporting a new bug when we uncheck the ‹ hide added devices › option.
I have a duplication of the first device that appears — is that normal?
I still have this 3 more times, always with the same MAC:

[pierre-gilles]

@AlexTrovato

I’ll set up the timeout asap.

Top! For info the library has a parameter « scanTimeout » so it’s really not hard to set up:

@AlexTrovato

I’ll try to make something clean, but it won’t be a priority. The « start scan » button goes from blue to red, like on Bluetooth, there’s just no animation.

2 fairly simple options to implement:

• Either you put the page in « loading » like we do everywhere with the spinner

I’m talking about this class:

• Or you put an « alert alert-primary » with a message « A scan is currently in progress… »

[AlexTrovato]

@pierre-gilles

you set the page to « loading » like we do everywhere with the spinner

That’s what I did at first, but with the auto-scan every 2 minutes lasting 1 minute, the user doesn’t have time to do what they want before the page is blocked again to be reloaded.

[quote=« spenceur, post:116, topic:6131 »]
Hello @AlexTrovato
I’m reporting a new bug when we uncheck the ‹ hide added devices › option.
I have a duplication of the first device that appears — is that normal?
I still have that 3 times, always with the same

[spenceur]

On the official image, I get it every time I uncheck the « hide » option

1. scan
2. add device
3. uncheck options
4. magically, lots of duplicates in the Discovery tab

I’m not doing anything special ^^

[pierre-gilles]

@AlexTrovato

That’s what I did at the beginning, but with the automatic scan every 2 minutes, lasting 1 minute, the user doesn’t have time to do what they want before the page is blocked again to be reloaded.

Ok I see, in that case the « alert alert-primary » at the top of the page might be an option